fix(cmdk): update search-modal assertions to the renamed New chat label - #6549
Merged
Merged
Conversation
#6543 renamed the ask-Sim label to sentence case but left the two assertions expecting 'New Chat', which has been failing Lint and Test on staging for every PR since.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryCursor Bugbot is generating a summary for commit 1ca5c7c. Configure here. |
Contributor
Greptile SummaryThis PR corrects two stale SearchModal test assertions to match the existing sentence-case “New chat” label.
Confidence Score: 5/5The PR appears safe to merge because both test-only changes accurately reflect the existing production label. The updated expectations match the hardcoded
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.test.tsx | Both assertions now match the production SearchModal label, with no actionable issues found. |
Reviews (1): Last reviewed commit: "fix(cmdk): update search-modal assertion..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New chat: ${query},search-modal.tsx:1094) but leftsearch-modal.test.tsx:152and:195assertingNew ChatTest and Build / Lint and Teston staging for every PR since, unrelated to whatever that PR changedType of Change
Testing
search-modal.test.tsx19/19 pass. Confirmed the same 2 failures reproduce on cleanorigin/stagingwithout this change.Checklist